lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/3] arm64: defconfig: Select CONFIG_RESET_IMX7 by default
Date
Hi, Arnd


> Subject: Re: [PATCH 2/3] arm64: defconfig: Select CONFIG_RESET_IMX7 by
> default
>
> On Mon, Jun 29, 2020 at 1:34 PM Anson Huang <anson.huang@nxp.com>
> wrote:
> > > Subject: Re: [PATCH 2/3] arm64: defconfig: Select CONFIG_RESET_IMX7
> > > by default
> > >
> > > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang
> <Anson.Huang@nxp.com>
> > > wrote:
> > > >
> > > > i.MX7 reset driver now supports module build, it is no longer
> > > > built in by default, need to select it explicitly.
> > > >
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > >
> > > Why not make it =m now that this is possible?
> >
> > It is because some drivers depends on this reset driver to work, such
> > as PCIe, If by default make it =m, it may impact PCIe's function,
> > adding module support at this point is try to provide function of
> > loadable module for Android, but don't want to impact any function which is
> working previously.
>
> It sounds like your patch 1/3 is not ready to be merged then.
>
> Please make sure that loading it later does not break other drivers that depend
> on it. Other drivers don't have to be able to deal with missing dependencies if
> this one is never loaded or disabled at compile-time. However before you
> make it possible to turn this into a loadable module, anything that depends on
> it must be able to deal with the modules getting loaded in a random order
> first.
>
I searched all driver which uses this reset driver, looks like ONLY i.MX6 PCIe is using it and
it ONLY supports built-in, and inside this driver, it does NOT support defer probe etc.,
since I am NOT sure when this PCIe driver will add module support, so do you think if I
can make PCI_IMX6 select RESET_IMX7, then it won't break the PCIe function even
RESET_IMX7 is set to =m in defconfig, as when PCI_IMX6 is enabled as =y, RESET_IMX7 will
be also =y.

config PCI_IMX6
bool "Freescale i.MX6/7/8 PCIe controller"
depends on ARCH_MXC || COMPILE_TEST
depends on PCI_MSI_IRQ_DOMAIN
select PCIE_DW_HOST

Thanks,
Anson
\
 
 \ /
  Last update: 2020-06-29 22:41    [W:0.070 / U:2.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site