lkml.org 
[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/5] Fix split view search and debug info navigation
From
Date
On Mon, 2020-06-29 at 11:35 +0200, Mauro Carvalho Chehab wrote:
> This series fixes some issues with search while on split view and fix the
> broken hyperlink navigation.
>
> The first patches restore the pre-Qt5 conversion behavior. The last
> one implements navigation on a different way. I opted to keep this one
> in separate, as this one is a new feature.
>
> Mauro Carvalho Chehab (5):
> kconfig: qconf: cleanup includes
> kconfig: qconf: ensure that only one item will be highlighted
> kconfig: qconf: make search fully work again on split mode
> kconfig: qconf: make debug links work again
> kconfig: qconf: navigate menus on hyperlinks
>
> scripts/kconfig/qconf.cc | 120 +++++++++++++++++++++++++++++----------
> scripts/kconfig/qconf.h | 15 ++---
> 2 files changed, 98 insertions(+), 37 deletions(-)
>
I tested the series, and it works really well here.
Thanks a lot for the patch 5, I indeed noted that
I am not sure it ever worked like that but it does now,
and it is a very good improvement in terms of usability.

There is still a tiny issue in patch 5 - sometimes already
selected items remain selected like it was in the search (now fixed).

Also I found another bug - clicking on '..' menu doesn't work:

For example select 'input device support', then 'keyboards' on the right,
then you can't get back. It also might be something that never worked,
and it doesn't bother me, I just note this for reference.

Thanks a lot for these fixes!
Best regards,
Maxim Levitsky

\
 
 \ /
  Last update: 2020-06-29 22:39    [W:0.102 / U:1.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site