[lkml]   [2020]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH RFC 2/5] usb:cdns3: Add pci to platform driver wrapper

>On Fri, Jun 26, 2020 at 06:54:47AM +0200, Pawel Laszczak wrote:
>> Patch adds PCI specific glue driver that creates and registers in-system
>> cdns-usbssp platform device.
>Ick, no.
>Platform devices are ONLY to be used for when you have a real platform
>device. If your device is a PCI device, use that. Don't try to be cute
>and make a platform device when you don't have one please.
>> Thanks to that we will be able to use
>> the cdns-usbssp platform driver for USBSS-DEV controller
>> build on PCI board.
>No, fix up that driver to not care about it being a platform device,
>make it just accept any type of 'struct device'.
Ok, I will remove it form this driver but probably in a few months I will have to add
such support.

So I'm going to merge patch 2/5 "usb:cdns3: Add pci to platform driver wrapper" with
main part of driver and remove patch 1/5 "dt-bindings: add binding for CDNSP-DRD controller".



 \ /
  Last update: 2020-06-29 20:47    [W:0.115 / U:3.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site