lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read()
    Date
    Until now the aforementioned return value has been ignored.
    Previous and current calls to tps65217_reg_read() return
    instantly when the value is not 0, so let's do that.

    Fixes the following W=1 warning:

    drivers/regulator/tps65217-regulator.c: In function ‘tps65217_regulator_probe’:
    drivers/regulator/tps65217-regulator.c:227:9: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
    227 | int i, ret;
    | ^~~

    Cc: Russ Dill <Russ.Dill@ti.com>
    Cc: Keerthy <j-keerthy@ti.com>
    Cc: AnilKumar Ch <anilkumar@ti.com>
    Cc: linux-omap@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/regulator/tps65217-regulator.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c
    index f2d3a4a9f3e77..3f5ea029e2e3f 100644
    --- a/drivers/regulator/tps65217-regulator.c
    +++ b/drivers/regulator/tps65217-regulator.c
    @@ -254,6 +254,9 @@ static int tps65217_regulator_probe(struct platform_device *pdev)

    /* Store default strobe info */
    ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
    + if (ret)
    + return ret;
    +
    tps->strobes[i] = val & regulators[i].bypass_mask;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-26 08:58    [W:4.236 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site