Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 26 Jun 2020 16:39:27 +0200 | Subject | Re: [PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused variable 'ret' |
| |
On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <lee.jones@linaro.org> wrote: > > Hasn't been checked since its conception 2 years ago. > > Squashes W=1 warning: > > drivers/misc/mic/vop/vop_main.c: In function ‘_vop_scan_devices’: > drivers/misc/mic/vop/vop_main.c:617:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > 617 | int ret; > | ^~~ > > Cc: Sudeep Dutt <sudeep.dutt@intel.com> > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
This is a correct change, but I'd take it one step further and make the _vop_remove_device() function return 'void' if you don't mind respinning the patch.
Either way
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |