[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v7 0/3] media: Add colors' order and other info over test image
This patchset aims to add a method to display the correct order of
colors for a test image generated. It does so by adding a function
which returns a string of correct order of the colors for a test
pattern. It then adds a control in vimc which displays the string
over test image. It also displays some other information like saturation,
hue, contrast brightness and time since the stream started over test
image generated by vimc.

Changes since v6:
In patch 3:
- Use switch case instead of if()
- reorder declarartions.

Changes since v5:
In patch 2:
- Add missing EXPORT_SYMBOL_GPL()
In patch 3:
- Renamed varaibles.
- use u64 instead of int for getting current time in
- Use enum instead of numbers to describe the state of osd_mode
control in code.

Changes since v4:
- Add another patch which changes char argument to const char
in function tpg_gen_text()
- Return const char * from function tpg_g_color_order() in patch
In 3rd patch:
- Check font in probe() instead of s_stream()
- Use dev_err instead of pr_err
- Fix errors in commit message.

Changes since v3:
In 1st patch:
-Improved formatting of returned string.

In 2nd patch:
- Add CID prefix in control name and change it to a more
generic name.
- Rename bool variable to a generic name.
- Disable text rendering instead of stopping stream if no
font found.
- Display more info like VIVID in VIMC.

Changes since v2:
In 1st patch:
- Create a 'define' to prevent repetition of the common color
sequence string.
- Use 'fallthrough' on case statement to prevent repetition of

Changes since v1:
- Divided the patch into two patches.
- Returned NULL for patterns whose color order cannot be
defined. (Reported-by: kernel test robot <>)
- Made separate switch cases for separate test patterns
(Reported-by: kernel test robot <>)
- Renamed variables from camelcase to use '_'
- prefixed 'media' to the patches.

Kaaira Gupta (3):
media: tpg: change char argument to const char
media: tpg: Add function to return colors' order of test image
media: vimc: Add a control to display info on test image

drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 40 +++++++++--
drivers/media/test-drivers/vimc/Kconfig | 2 +
drivers/media/test-drivers/vimc/vimc-common.h | 1 +
drivers/media/test-drivers/vimc/vimc-core.c | 10 +++
drivers/media/test-drivers/vimc/vimc-sensor.c | 70 +++++++++++++++++++
include/media/tpg/v4l2-tpg.h | 3 +-
6 files changed, 118 insertions(+), 8 deletions(-)


 \ /
  Last update: 2020-06-26 15:07    [W:0.066 / U:1.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site