lkml.org 
[lkml]   [2020]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs
    Date
    The number of output clocks are configurable in the hardware.
    Currently the driver registers the maximum number of outputs.
    Fix the same by registering only the outputs that are there.

    Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
    ---
    v4:
    Assign output in this patch

    drivers/clk/clk-xlnx-clock-wizard.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c
    index 8a7f9bb..28bbaa0 100644
    --- a/drivers/clk/clk-xlnx-clock-wizard.c
    +++ b/drivers/clk/clk-xlnx-clock-wizard.c
    @@ -495,6 +495,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
    const char *clk_name;
    struct clk_wzrd *clk_wzrd;
    struct resource *mem;
    + int outputs;
    struct device_node *np = pdev->dev.of_node;

    clk_wzrd = devm_kzalloc(&pdev->dev, sizeof(*clk_wzrd), GFP_KERNEL);
    @@ -565,6 +566,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
    goto err_disable_clk;
    }

    + outputs = of_property_count_strings(np, "clock-output-names");
    /* register div */
    reg = (readl(clk_wzrd->base + WZRD_CLK_CFG_REG(0)) &
    WZRD_DIVCLK_DIVIDE_MASK) >> WZRD_DIVCLK_DIVIDE_SHIFT;
    @@ -586,7 +588,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
    }

    /* register div per output */
    - for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
    + for (i = outputs - 1; i >= 0 ; i--) {
    const char *clkout_name;

    if (of_property_read_string_index(np, "clock-output-names", i,
    @@ -617,7 +619,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
    if (IS_ERR(clk_wzrd->clkout[i])) {
    int j;

    - for (j = i + 1; j < WZRD_NUM_OUTPUTS; j++)
    + for (j = i + 1; j < outputs; j++)
    clk_unregister(clk_wzrd->clkout[j]);
    dev_err(&pdev->dev,
    "unable to register divider clock\n");
    --
    2.1.1
    \
     
     \ /
      Last update: 2020-06-26 14:43    [W:3.576 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site