lkml.org 
[lkml]   [2020]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/50] staging: mmal-vchiq: Avoid use of bool in structures
From
Date
On Tue, 2020-06-23 at 15:11 -0700, Joe Perches wrote:
> On Tue, 2020-06-23 at 18:41 +0200, Nicolas Saenz Julienne wrote:
> > From: Dave Stevenson <dave.stevenson@raspberrypi.org>
> >
> > Fixes up a checkpatch error "Avoid using bool structure members
> > because of possible alignment issues".
> []
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> []
> > @@ -1754,7 +1754,7 @@ int vchiq_mmal_component_enable(struct
> > vchiq_mmal_instance *instance,
> >
> > ret = enable_component(instance, component);
> > if (ret == 0)
> > - component->enabled = true;
> > + component->enabled = 1;
>
> This change does not match the commit description.
>
> Also, checkpatch does not emit a warning here.

Fair enough I'll drop it for v2.

Regards,
Nicolas

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-06-24 12:27    [W:1.298 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site