lkml.org 
[lkml]   [2020]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/2] net: macb: call pm_runtime_put_sync on failure path
    Date
    Call pm_runtime_put_sync() on failure path of at91ether_open.

    Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on at91rm9200")
    Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
    ---

    Changes in v2:
    - this patch is new in v2
    - patch 2/2 in this series is based on this one

    drivers/net/ethernet/cadence/macb_main.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
    index 67933079aeea..96d62d73b933 100644
    --- a/drivers/net/ethernet/cadence/macb_main.c
    +++ b/drivers/net/ethernet/cadence/macb_main.c
    @@ -3835,7 +3835,7 @@ static int at91ether_open(struct net_device *dev)

    ret = at91ether_start(dev);
    if (ret)
    - return ret;
    + goto pm_exit;

    /* Enable MAC interrupts */
    macb_writel(lp, IER, MACB_BIT(RCOMP) |
    @@ -3848,11 +3848,15 @@ static int at91ether_open(struct net_device *dev)

    ret = macb_phylink_connect(lp);
    if (ret)
    - return ret;
    + goto pm_exit;

    netif_start_queue(dev);

    return 0;
    +
    +pm_exit:
    + pm_runtime_put_sync(&lp->pdev->dev);
    + return ret;
    }

    /* Close the interface */
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-06-24 12:08    [W:3.542 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site