lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.19 066/206] soundwire: slave: dont init debugfs on device registration error
    On Tue, Jun 23, 2020 at 11:11:03PM +0200, Pavel Machek wrote:
    >Hi!
    >
    >> [ Upstream commit 8893ab5e8ee5d7c12e0fc1dca4a309475064473d ]
    >>
    >> The error handling flow seems incorrect, there is no reason to try and
    >> add debugfs support if the device registration did not
    >> succeed. Return on error.
    >
    >> +++ b/drivers/soundwire/slave.c
    >> @@ -55,6 +55,8 @@ static int sdw_slave_add(struct sdw_bus *bus,
    >> list_del(&slave->node);
    >> mutex_unlock(&bus->bus_lock);
    >> put_device(&slave->dev);
    >> +
    >> + return ret;
    >> }
    >>
    >> return ret;
    >
    >Mainline is significantly different here; this patch does not make
    >sense in v4.19 -- as it does not do anything.

    I've dropped it from 4.19, thanks!

    --
    Thanks,
    Sasha

    \
     
     \ /
      Last update: 2020-06-24 02:57    [W:4.482 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site