lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 192/206] mtd: rawnand: plat_nand: Fix the probe error path
    Date
    From: Miquel Raynal <miquel.raynal@bootlin.com>

    [ Upstream commit 5284024b4dac5e94f7f374ca905c7580dbc455e9 ]

    nand_release() is supposed be called after MTD device registration.
    Here, only nand_scan() happened, so use nand_cleanup() instead.

    There is no real Fixes tag applying here as the use of nand_release()
    in this driver predates by far the introduction of nand_cleanup() in
    commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
    which makes this change possible, hence pointing it as the commit to
    fix for backporting purposes, even if this commit is not introducing
    any bug.

    Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-43-miquel.raynal@bootlin.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/nand/raw/plat_nand.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mtd/nand/raw/plat_nand.c b/drivers/mtd/nand/raw/plat_nand.c
    index d65e4084dea48..27365bd8675cd 100644
    --- a/drivers/mtd/nand/raw/plat_nand.c
    +++ b/drivers/mtd/nand/raw/plat_nand.c
    @@ -97,7 +97,7 @@ static int plat_nand_probe(struct platform_device *pdev)
    if (!err)
    return err;

    - nand_release(&data->chip);
    + nand_cleanup(&data->chip);
    out:
    if (pdata->ctrl.remove)
    pdata->ctrl.remove(pdev);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:44    [W:5.987 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site