lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 242/314] afs: Fix memory leak in afs_put_sysnames()
    Date
    From: Zhihao Cheng <chengzhihao1@huawei.com>

    [ Upstream commit 2ca068be09bf8e285036603823696140026dcbe7 ]

    Fix afs_put_sysnames() to actually free the specified afs_sysnames
    object after its reference count has been decreased to zero and
    its contents have been released.

    Fixes: 6f8880d8e681557 ("afs: Implement @sys substitution handling")
    Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/afs/proc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/afs/proc.c b/fs/afs/proc.c
    index fba2ec3a3a9c9..106b27011f6d5 100644
    --- a/fs/afs/proc.c
    +++ b/fs/afs/proc.c
    @@ -562,6 +562,7 @@ void afs_put_sysnames(struct afs_sysnames *sysnames)
    if (sysnames->subs[i] != afs_init_sysname &&
    sysnames->subs[i] != sysnames->blank)
    kfree(sysnames->subs[i]);
    + kfree(sysnames);
    }
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:31    [W:2.765 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site