lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 392/477] afs: Fix non-setting of mtime when writing into mmap
    Date
    From: David Howells <dhowells@redhat.com>

    [ Upstream commit bb413489288e4e457353bac513fddb6330d245ca ]

    The mtime on an inode needs to be updated when a write is made into an
    mmap'ed section. There are three ways in which this could be done: update
    it when page_mkwrite is called, update it when a page is changed from dirty
    to writeback or leave it to the server and fix the mtime up from the reply
    to the StoreData RPC.

    Found with the generic/215 xfstest.

    Fixes: 1cf7a1518aef ("afs: Implement shared-writeable mmap")
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/afs/write.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/afs/write.c b/fs/afs/write.c
    index cb76566763dba..371db86c6c5ec 100644
    --- a/fs/afs/write.c
    +++ b/fs/afs/write.c
    @@ -811,6 +811,7 @@ vm_fault_t afs_page_mkwrite(struct vm_fault *vmf)
    vmf->page->index, priv);
    SetPagePrivate(vmf->page);
    set_page_private(vmf->page, priv);
    + file_update_time(file);

    sb_end_pagefault(inode->i_sb);
    return VM_FAULT_LOCKED;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:17    [W:2.129 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site