lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 104/477] scsi: sr: Fix sr_probe() missing mutex_destroy
    Date
    From: Simon Arlott <simon@octiron.net>

    [ Upstream commit a247e07f8dadba5da9f188aaf4f96db0302146d9 ]

    If the device minor cannot be allocated or the cdrom fails to be registered
    then the mutex should be destroyed.

    Link: https://lore.kernel.org/r/06e9de38-eeed-1cab-5e08-e889288935b3@0882a8b5-c6c3-11e9-b005-00805fc181fe
    Fixes: 51a858817dcd ("scsi: sr: get rid of sr global mutex")
    Signed-off-by: Simon Arlott <simon@octiron.net>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/sr.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
    index d2fe3fa470f95..8d062d4f3ce0b 100644
    --- a/drivers/scsi/sr.c
    +++ b/drivers/scsi/sr.c
    @@ -817,6 +817,7 @@ static int sr_probe(struct device *dev)

    fail_put:
    put_disk(disk);
    + mutex_destroy(&cd->lock);
    fail_free:
    kfree(cd);
    fail:
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:07    [W:2.413 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site