lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 068/477] usb: cdns3: Fix runtime PM imbalance on error
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit e5b913496099527abe46e175e5e2c844367bded0 ]

    pm_runtime_get_sync() increments the runtime PM usage counter even
    when it returns an error code. Thus a pairing decrement is needed on
    the error handling path to keep the counter balanced.

    Reviewed-by: Peter Chen <peter.chen@nxp.com>
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/cdns3/cdns3-ti.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c
    index 5685ba11480bd..e701ab56b0a76 100644
    --- a/drivers/usb/cdns3/cdns3-ti.c
    +++ b/drivers/usb/cdns3/cdns3-ti.c
    @@ -138,7 +138,7 @@ static int cdns_ti_probe(struct platform_device *pdev)
    error = pm_runtime_get_sync(dev);
    if (error < 0) {
    dev_err(dev, "pm_runtime_get_sync failed: %d\n", error);
    - goto err_get;
    + goto err;
    }

    /* assert RESET */
    @@ -185,7 +185,6 @@ static int cdns_ti_probe(struct platform_device *pdev)

    err:
    pm_runtime_put_sync(data->dev);
    -err_get:
    pm_runtime_disable(data->dev);

    return error;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:05    [W:4.904 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site