Messages in this thread | | | Subject | Re: [PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce | From | "luobin (L)" <> | Date | Tue, 23 Jun 2020 14:41:10 +0800 |
| |
On 2020/6/23 6:08, Jakub Kicinski wrote: >> + if (coal->tx_max_coalesced_frames > COALESCE_MAX_PENDING_LIMIT) { >> + netif_err(nic_dev, drv, netdev, >> + "Tx_max_coalesced_frames out of range[%d-%d]\n", 0, >> + COALESCE_MAX_PENDING_LIMIT); >> + return -EOPNOTSUPP; >> + } >> + >> + return 0; >> +} > I think ERANGE is a more appropriate error code in these? Will fix. Thanks for your review.
| |