lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 12/15] dt-bindings: mdio: add phy-supply property to ethernet phy node
    From
    Date
    On 6/22/20 2:37 AM, Bartosz Golaszewski wrote:
    > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    >
    > The phy-supply property is often added to MAC nodes but this is wrong
    > conceptually. These supplies should be part of the PHY node on the
    > MDIO bus. Add phy-supply property at PHY level to mdio.yaml.
    >
    > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    > ---
    > Documentation/devicetree/bindings/net/mdio.yaml | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml
    > index d6a3bf8550eb..9c10012c2093 100644
    > --- a/Documentation/devicetree/bindings/net/mdio.yaml
    > +++ b/Documentation/devicetree/bindings/net/mdio.yaml
    > @@ -90,6 +90,10 @@ patternProperties:
    > Delay after the reset was deasserted in microseconds. If
    > this property is missing the delay will be skipped.
    >
    > + phy-supply:
    > + description:
    > + Phandle to the regulator that provides the supply voltage to the PHY.

    I do not see how you can come up with a generic name here, there could
    be PHYs supporting different voltages (3.3V, 1.8V, 1.5V) depending on
    their operation mode/strapping, there can also be different parts of the
    PHY being powered by different regulators, the analog part could be on
    an always-on island such that Wake-on-LAN from the PHY could be done,
    and the digital part could be on a complete different island.
    --
    Florian

    \
     
     \ /
      Last update: 2020-06-23 21:41    [W:4.074 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site