Messages in this thread | | | Subject | Re: [PATCH] drm/msm/dpu: Fix usage of ERR_PTR() | From | Zenghui Yu <> | Date | Sat, 20 Jun 2020 18:26:30 +0800 |
| |
ping for this obvious fix...
On 2020/5/28 21:08, Zenghui Yu wrote: > ERR_PTR() is used in the kernel to encode an usual *negative* errno code > into a pointer. Passing a positive value (ENOMEM) to it will break the > following IS_ERR() check. > > Though memory allocation is unlikely to fail, it's still worth fixing. > And grepping shows that this is the only misuse of ERR_PTR() in kernel. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index a1b79ee2bd9d..a2f6b688a976 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -2173,7 +2173,7 @@ struct drm_encoder *dpu_encoder_init(struct drm_device *dev, > > dpu_enc = devm_kzalloc(dev->dev, sizeof(*dpu_enc), GFP_KERNEL); > if (!dpu_enc) > - return ERR_PTR(ENOMEM); > + return ERR_PTR(-ENOMEM); > > rc = drm_encoder_init(dev, &dpu_enc->base, &dpu_encoder_funcs, > drm_enc_mode, NULL); >
| |