Messages in this thread | | | Date | Tue, 2 Jun 2020 07:51:52 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2() |
| |
On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote: > But does this code path actually show up anywhere that is actually > measurable as mattering? > > If so, please show that benchmark results.
I think the requests are starting to be a bit unreasonable. Tao is replacing a reimplementation of a standard function with that standard function / compiler builtin. We don't put such a high burden on that.
And once the proper existing fields are used where possible as shown in my reply just replacing the rest seems totally obvious - quite contrary I think keeping a reimplementation would need a high bar.
| |