Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 2 Jun 2020 18:35:46 +0300 | Subject | Re: [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate |
| |
On Tue, Jun 2, 2020 at 12:25 PM Piotr Stankiewicz <piotr.stankiewicz@intel.com> wrote: > > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it.
...
> - unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI; > + unsigned int flags = PCI_IRQ_MSI_TYPES; > > if (!pci_is_pcie(dd->pcidev)) { > qib_dev_err(dd, "Can't find PCI Express capability!\n");
Internally I have proposed at last this:
convert the following if (dd->flags & QIB_HAS_INTX) flags |= PCI_IRQ_LEGACY;
to if (dd->flags & QIB_HAS_INTX) flags = PCI_IRQ_ALL_TYPES; if (dd->flags & QIB_HAS_INTX) flags = PCI_IRQ_MSI_TYPES;
-- With Best Regards, Andy Shevchenko
| |