Messages in this thread | | | From | "Stankiewicz, Piotr" <> | Subject | RE: [PATCH 07/15] drm/amdgpu: use PCI_IRQ_MSI_TYPES where appropriate | Date | Tue, 2 Jun 2020 09:57:45 +0000 |
| |
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Tuesday, June 2, 2020 11:49 AM > To: Stankiewicz, Piotr <piotr.stankiewicz@intel.com> > Cc: Alex Deucher <alexander.deucher@amd.com>; Christian König > <christian.koenig@amd.com>; David Zhou <David1.Zhou@amd.com>; David > Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; amd- > gfx@lists.freedesktop.org; dri-devel <dri-devel@lists.freedesktop.org>; Linux > Kernel Mailing List <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH 07/15] drm/amdgpu: use PCI_IRQ_MSI_TYPES where > appropriate > > On Tue, Jun 2, 2020 at 12:24 PM Piotr Stankiewicz > <piotr.stankiewicz@intel.com> wrote: > > > > Seeing as there is shorthand available to use when asking for any type > > of interrupt, or any type of message signalled interrupt, leverage it. > > > > Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > > index 5ed4227f304b..6dbe173a9fd4 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > > @@ -251,11 +251,11 @@ int amdgpu_irq_init(struct amdgpu_device *adev) > > int nvec = pci_msix_vec_count(adev->pdev); > > unsigned int flags; > > > > - if (nvec <= 0) { > > + if (nvec > 0) > > + flags = PCI_IRQ_MSI_TYPES; > > + else > > flags = PCI_IRQ_MSI; > > - } else { > > - flags = PCI_IRQ_MSI | PCI_IRQ_MSIX; > > - } > > + > > /* we only need one vector */ > > nvec = pci_alloc_irq_vectors(adev->pdev, 1, 1, flags); > > I'm not sure if you have seen my last comment internally about this patch. > > I don't understand why we need these pci_msix_vec_count() followed by > conditional at all. > Perhaps we may simple drop all these and supply flag directly? > > But OTOH, I don't know the initial motivation, so, the above patch is > non-intrusive and keeps original logic. >
Sorry, I must have misunderstood or missed that comment. I am happy to do a V2 if dropping the conditional is preferable.
> > if (nvec > 0) { > > -- > > 2.17.2 > > > > > -- > With Best Regards, > Andy Shevchenko
BR, Piotr Stankiewicz
| |