Messages in this thread | | | Date | Tue, 2 Jun 2020 16:51:48 +0800 | From | Xiao Yang <> | Subject | Re: [PATCH] xfs/XXX: Add xfs/XXX |
| |
On 2020/4/14 0:30, Darrick J. Wong wrote: > This might be a good time to introduce a few new helpers: > > _require_scratch_dax ("Does $SCRATCH_DEV support DAX?") > _require_scratch_dax_mountopt ("Does the fs support the DAX mount options?") > _require_scratch_daX_iflag ("Does the fs support FS_XFLAG_DAX?") Hi Darrick,
Now, I am trying to introduce these new helpers and have some questions: 1) There are five testcases related to old dax implementation, should we only convert them to new dax implementation or make them compatible with old and new dax implementation?
2) I think _require_xfs_io_command "chattr" "x" is enough to check if fs supports FS_XFLAG_DAX. Is it necessary to add _require_scratch_dax_iflag()? like this: _require_scratch_dax_iflag() { _require_xfs_io_command "chattr" "x" }
Best Regards, Xiao Yang
| |