lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC - kernel selftest result documentation (KTAP)
On Fri, Jun 19, 2020 at 01:47:29PM -0500, Frank Rowand wrote:
> On 2020-06-16 18:58, Kees Cook wrote:
> > I proposed fixing that recently[1]. seccomp uses XFAIL for "I have
> > detected you lack the config to test this, so I can't say it's working
> > or not, because it only looks like a failure without the config."
>
> Based on that description, the case sounds like it should be a skip.

hrm hrm. Yeah. Thinking more about this, I agree. I think it came about
this way because the kselftest_harness.h API (not TAP output) is different from the
kselftest.h API (TAP output), and so the tests were written with what
was available in kselftest_harness.h which has no "SKIP" idea.

The series linked was mostly built to bring kselftest_harness.h into the
TAP output universe, so the XFAIL -> SKIP mapping needs to be included
as well.

> Or if the entire test depends on the missing config then Bail out might
> be appropriate.
>
> > [1] https://lore.kernel.org/lkml/20200611224028.3275174-7-keescook@chromium.org/

I will rework this series.

--
Kees Cook

\
 
 \ /
  Last update: 2020-06-19 21:12    [W:0.069 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site