lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch
From
Date
On Fri, 2020-06-19 at 20:08 +0200, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.

This is too many changes in a single patch to verify
them easily.

If you really want to change this file, and it's likely
not particularly necessary, I suggest that you send a
patch series that where each patch individually does:

1: Horizontal whitespace only changes
o Trim trailing whitespace
o Add alignment whitespace
o Add operator spacing whitespace
2: Vertical whitespace changes if any
3: Convert embedded assignments to multiple lines
4: Comment style updates

And whatever other specific style changes necessary
to properly and easily identify them as correct.


\
 
 \ /
  Last update: 2020-06-19 20:30    [W:0.327 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site