lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 082/190] spi: dw: Zero DMA Tx and Rx configurations on stack
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    [ Upstream commit 3cb97e223d277f84171cc4ccecab31e08b2ee7b5 ]

    Some DMA controller drivers do not tolerate non-zero values in
    the DMA configuration structures. Zero them to avoid issues with
    such DMA controller drivers. Even despite above this is a good
    practice per se.

    Fixes: 7063c0d942a1 ("spi/dw_spi: add DMA support")
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Acked-by: Feng Tang <feng.tang@intel.com>
    Cc: Feng Tang <feng.tang@intel.com>
    Link: https://lore.kernel.org/r/20200506153025.21441-1-andriy.shevchenko@linux.intel.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-dw-mid.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/spi/spi-dw-mid.c b/drivers/spi/spi-dw-mid.c
    index 837cb8d0bac6..4f41d44e8b4c 100644
    --- a/drivers/spi/spi-dw-mid.c
    +++ b/drivers/spi/spi-dw-mid.c
    @@ -155,6 +155,7 @@ static struct dma_async_tx_descriptor *dw_spi_dma_prepare_tx(struct dw_spi *dws,
    if (!xfer->tx_buf)
    return NULL;

    + memset(&txconf, 0, sizeof(txconf));
    txconf.direction = DMA_MEM_TO_DEV;
    txconf.dst_addr = dws->dma_addr;
    txconf.dst_maxburst = 16;
    @@ -201,6 +202,7 @@ static struct dma_async_tx_descriptor *dw_spi_dma_prepare_rx(struct dw_spi *dws,
    if (!xfer->rx_buf)
    return NULL;

    + memset(&rxconf, 0, sizeof(rxconf));
    rxconf.direction = DMA_DEV_TO_MEM;
    rxconf.src_addr = dws->dma_addr;
    rxconf.src_maxburst = 16;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-19 18:38    [W:4.114 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site