lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 119/267] net: vmxnet3: fix possible buffer overflow caused by bad DMA value in vmxnet3_get_rss()
    Date
    From: Jia-Ju Bai <baijiaju1990@gmail.com>

    [ Upstream commit 3e1c6846b9e108740ef8a37be80314053f5dd52a ]

    The value adapter->rss_conf is stored in DMA memory, and it is assigned
    to rssConf, so rssConf->indTableSize can be modified at anytime by
    malicious hardware. Because rssConf->indTableSize is assigned to n,
    buffer overflow may occur when the code "rssConf->indTable[n]" is
    executed.

    To fix this possible bug, n is checked after being used.

    Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/vmxnet3/vmxnet3_ethtool.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
    index 559db051a500..88d18ab83e54 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
    @@ -692,6 +692,8 @@ vmxnet3_get_rss(struct net_device *netdev, u32 *p, u8 *key, u8 *hfunc)
    *hfunc = ETH_RSS_HASH_TOP;
    if (!p)
    return 0;
    + if (n > UPT1_RSS_MAX_IND_TABLE_SIZE)
    + return 0;
    while (n--)
    p[n] = rssConf->indTable[n];
    return 0;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-19 18:25    [W:4.046 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site