lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 279/376] evm: Fix possible memory leak in evm_calc_hmac_or_hash()
    Date
    From: Roberto Sassu <roberto.sassu@huawei.com>

    commit 0c4395fb2aa77341269ea619c5419ea48171883f upstream.

    Don't immediately return if the signature is portable and security.ima is
    not present. Just set error so that memory allocated is freed before
    returning from evm_calc_hmac_or_hash().

    Fixes: 50b977481fce9 ("EVM: Add support for portable signature format")
    Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    security/integrity/evm/evm_crypto.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/security/integrity/evm/evm_crypto.c
    +++ b/security/integrity/evm/evm_crypto.c
    @@ -241,7 +241,7 @@ static int evm_calc_hmac_or_hash(struct

    /* Portable EVM signatures must include an IMA hash */
    if (type == EVM_XATTR_PORTABLE_DIGSIG && !ima_present)
    - return -EPERM;
    + error = -EPERM;
    out:
    kfree(xattr_value);
    kfree(desc);

    \
     
     \ /
      Last update: 2020-06-19 17:55    [W:4.158 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site