lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] io_uring: add support for zone-append
From
Date
On 6/19/20 9:22 AM, Alexey Dobriyan wrote:
>> uint64_t val = cqe->res; // assuming non-error here
>>
>> if (cqe->flags & IORING_CQE_F_ZONE_FOO)
>> val |= (cqe->flags >> 16) << 32ULL;
>
> Jens, ULL in shift doesn't do anything for widening the result.
> You need
>
> val |= (uint64_t)(cqe->flags >> 16) << 32;

You're right of course, guess I should check my in-mail code a bit
better :-)

--
Jens Axboe

\
 
 \ /
  Last update: 2020-06-19 17:52    [W:0.031 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site