lkml.org 
[lkml]   [2020]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 131/376] net: bcmgenet: set Rx mode before starting netif
    Date
    From: Doug Berger <opendmb@gmail.com>

    [ Upstream commit 72f96347628e73dbb61b307f18dd19293cc6792a ]

    This commit explicitly calls the bcmgenet_set_rx_mode() function when
    the network interface is started. This function is normally called by
    ndo_set_rx_mode when the flags are changed, but apparently not when
    the driver is suspended and resumed.

    This change ensures that address filtering or promiscuous mode are
    properly restored by the driver after the MAC may have been reset.

    Fixes: b6e978e50444 ("net: bcmgenet: add suspend/resume callbacks")
    Signed-off-by: Doug Berger <opendmb@gmail.com>
    Acked-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    index 79636c78127c..38bdfd4b46f0 100644
    --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    @@ -70,6 +70,9 @@
    #define GENET_RDMA_REG_OFF (priv->hw_params->rdma_offset + \
    TOTAL_DESC * DMA_DESC_SIZE)

    +/* Forward declarations */
    +static void bcmgenet_set_rx_mode(struct net_device *dev);
    +
    static inline void bcmgenet_writel(u32 value, void __iomem *offset)
    {
    /* MIPS chips strapped for BE will automagically configure the
    @@ -2803,6 +2806,7 @@ static void bcmgenet_netif_start(struct net_device *dev)
    struct bcmgenet_priv *priv = netdev_priv(dev);

    /* Start the network engine */
    + bcmgenet_set_rx_mode(dev);
    bcmgenet_enable_rx_napi(priv);

    umac_enable_set(priv, CMD_TX_EN | CMD_RX_EN, true);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-19 17:25    [W:4.239 / U:1.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site