Messages in this thread |  | | Subject | Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret | | From | Horia Geantă <> | | Date | Thu, 18 Jun 2020 16:16:29 +0300 |
| |
On 6/18/2020 2:00 PM, Herbert Xu wrote: > On Thu, Jun 18, 2020 at 01:54:55PM +0300, Horia Geantă wrote: >> >> The proper fix would be updating the ahash_finup_no_ctx() function >> to return the specific error code: >> return ret; >> instead of returning -ENOMEM for all error cases. >> >> For example error code returned by dpaa2_caam_enqueue() >> should be returned instead of -ENOMEM. > > You can do that as a follow-up. The patch is correct as is. > Just that the follow-up implies adding all the code back.
Anyway, not a big deal...
Thanks, Horia
|  |