Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Don't compile GPIO bits if not CONFIG_OF_GPIO | From | Neil Armstrong <> | Date | Thu, 18 Jun 2020 10:05:48 +0200 |
| |
Hi Doug,
On 15/06/2020 16:36, Doug Anderson wrote: > Hi, > > On Fri, Jun 12, 2020 at 12:31 PM Douglas Anderson <dianders@chromium.org> wrote: >> >> The kernel test robot noted that if "OF" is defined (which is needed >> to select DRM_TI_SN65DSI86 at all) but not OF_GPIO that we'd get >> compile failures because some of the members that we access in "struct >> gpio_chip" are only defined "#if defined(CONFIG_OF_GPIO)". >> >> All the GPIO bits in the driver are all nicely separated out. We'll >> guard them with the same "#if defined" that the header has and add a >> little stub function if OF_GPIO is not defined. >> >> Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") >> Reported-by: kernel test robot <lkp@intel.com> >> Signed-off-by: Douglas Anderson <dianders@chromium.org> >> Reviewed-by: Stephen Boyd <swboyd@chromium.org> >> --- >> >> Changes in v2: None >> >> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) > > The kernel test robot gave me another yell over the weekend. I think > the whole series is ready to land, but if nothing else could at least > patch #1 land to fix the build error so the robot is happy?
I'm pushing the serie to drm-misc-next
Neil
> > -Doug >
| ![\](/images/icornerr.gif) |