Messages in this thread | | | Date | Thu, 18 Jun 2020 20:11:30 -0700 (PDT) | Subject | Re: [PATCH v2 net 0/2] Reapply DSA fix for dpaa-eth with proper Fixes: tag | From | David Miller <> |
| |
From: Vladimir Oltean <olteanv@gmail.com> Date: Tue, 16 Jun 2020 18:19:08 +0300
> From: Vladimir Oltean <vladimir.oltean@nxp.com> > > Joakim notified me that this fix breaks stable trees. > It turns out that my assessment about who-broke-who was wrong. > The real Fixes: tag should have been: > > Fixes: 060ad66f9795 ("dpaa_eth: change DMA device") > > which changes the device on which SET_NETDEV_DEV is made. > > git describe --tags 060ad66f97954 > v5.4-rc3-783-g060ad66f9795 > > Which means that it shouldn't have been backported to 4.19 and below. > This series reverts the commit with the misleading commit message, and > reapplies it with a corrected one. The resulting code is exactly the > same, but now, the revert should make it to the stable trees (along with > the bad fix), and the new fix should only make it down to v5.4.y. > > Changes in v2: > Corrected the reversed sysfs paths in the new commit description.
This is so messy.
What's done is done, just submit the necessary revert to -stable if necessary and let's not just change things back and forth because then we'll have two commits which make identical changes and each having a different Fixes: tag which is confusing.
Thanks.
| |