Messages in this thread Patch in this message | | | Date | Thu, 18 Jun 2020 09:47:50 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: gasket: replace symbolic permissions |
| |
On Mon, Jun 01, 2020 at 12:52:40AM +0000, Rodolfo C. Villordo wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. > + .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \ > warning detected by checkpatch.pl > > Signed-off-by: Rodolfo C. Villordo <rodolfovillordo@gmail.com> > --- > drivers/staging/gasket/gasket_sysfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h > index ab5aa351d555..d5e167dfbe76 100644 > --- a/drivers/staging/gasket/gasket_sysfs.h > +++ b/drivers/staging/gasket/gasket_sysfs.h > @@ -71,7 +71,7 @@ struct gasket_sysfs_attribute { > > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \ > { \ > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \ > + .attr = __ATTR(_name, 0444, _show_function, NULL), \
What about using __ATTR_RO() instead?
thanks,
greg k-h
| |