lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v2 13/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based
From
Date
17.06.2020 04:41, Sowjanya Komatineni пишет:
> Tegra CSI driver need a separate MIPI device for each channel as
> calibration of corresponding MIPI pads for each channel should
> happen independently.
>
> So, this patch updates tegra_mipi_request() API to add a device_node
> pointer argument to allow creating mipi device for specific device
> node rather than a device.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> drivers/gpu/drm/tegra/dsi.c | 2 +-
> drivers/gpu/host1x/mipi.c | 7 +++++--
> include/linux/host1x.h | 3 ++-
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
> index 38beab9..0443589 100644
> --- a/drivers/gpu/drm/tegra/dsi.c
> +++ b/drivers/gpu/drm/tegra/dsi.c
> @@ -1618,7 +1618,7 @@ static int tegra_dsi_probe(struct platform_device *pdev)
> if (IS_ERR(dsi->regs))
> return PTR_ERR(dsi->regs);
>
> - dsi->mipi = tegra_mipi_request(&pdev->dev);
> + dsi->mipi = tegra_mipi_request(&pdev->dev, NULL);
> if (IS_ERR(dsi->mipi))
> return PTR_ERR(dsi->mipi);
>
> diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
> index e00809d..93b354b 100644
> --- a/drivers/gpu/host1x/mipi.c
> +++ b/drivers/gpu/host1x/mipi.c
> @@ -206,13 +206,16 @@ static int tegra_mipi_power_down(struct tegra_mipi *mipi)
> return 0;
> }
>
> -struct tegra_mipi_device *tegra_mipi_request(struct device *device)
> +struct tegra_mipi_device *tegra_mipi_request(struct device *device,
> + struct device_node *np)
> {
> - struct device_node *np = device->of_node;
> struct tegra_mipi_device *dev;
> struct of_phandle_args args;
> int err;
>
> + if (!np)
> + np = device->of_node;

Will be nicer if DSI panel could pass the device's node directly,
instead of this.

\
 
 \ /
  Last update: 2020-06-18 02:28    [W:0.181 / U:2.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site