Messages in this thread | | | Date | Tue, 16 Jun 2020 12:52:24 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 1/2] power: supply: bq27xxx_battery: Notify about all battery changes |
| |
On Tue 2020-05-26 21:24:39, Andrew F. Davis wrote: > On 5/25/20 10:11 AM, Krzysztof Kozlowski wrote: > > All battery related data could be important for user-space. For example > > time-to-full could be shown to user on the screen or health could be > > monitored for any issues. Instead of comparing few selected old/new > > values, just check if anything changed in the cache. > > > > > At least some value will change every time we poll the battery, are we > okay with having power_supply_changed() called every time?
I believe that's very bad idea. AFAICT that would wake up userspace every 5 seconds, eating power in unexpected way, and without easy ability of opting out. IOW a regression.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |