lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] rcu: Fixup noinstr warnings
On Mon, Jun 15, 2020 at 05:30:52PM +0200, Peter Zijlstra wrote:
> On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote:
>
> > > // RCU is now watching. Better not be in an extended quiescent state!
> > > rcu_dynticks_task_trace_exit(); // After ->dynticks update!
> > > WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) &&
> > > !(seq & RCU_DYNTICK_CTRL_CTR));
> > > if (seq & RCU_DYNTICK_CTRL_MASK) {
> > > - atomic_andnot(RCU_DYNTICK_CTRL_MASK, &rdp->dynticks);
> > > + arch_atomic_andnot(RCU_DYNTICK_CTRL_MASK, &rdp->dynticks);
> >
> > This one is gone in -rcu.
>
> I'm still seeing that in mainline, was that removal scheduled for next
> round?

Yes. Unlike the few commits following it, this commit seems to work
fine even with the recent changes in mainline.

> > > smp_mb__after_atomic(); /* _exit after clearing mask. */
> > > }
> > > }
>
> What shall we do with this patch?

I plan to submit it to the v5.9 merge window. Do you need it to get
to mainline earlier?

Thanx, Paul

\
 
 \ /
  Last update: 2020-06-15 17:52    [W:0.224 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site