lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC
    On Mon, Jun 15, 2020 at 05:56:09PM +0530, Tamseel Shams wrote:
    > In few older Samsung SoCs like s3c2410, s3c2412
    > and s3c2440, UART IP is having 2 interrupt lines.
    > However, in other SoCs like s3c6400, s5pv210,
    > exynos5433, and exynos4210 UART is having only 1
    > interrupt line. Due to this, "platform_get_irq(platdev, 1)"
    > call in the driver gives the following warning:
    > "IRQ index 1 not found" on recent platforms.
    >
    > This patch re-factors the IRQ resources handling for
    > each platform and hence fixing the above warnings seen
    > on some platforms.
    >
    > Signed-off-by: Tamseel Shams <m.shams@samsung.com>
    > ---
    > drivers/tty/serial/samsung_tty.c | 20 ++++++++++++++++----
    > 1 file changed, 16 insertions(+), 4 deletions(-)

    RFC means "I do not trust this so I don't want anyone to merge it", so
    I'll just delete it from my queue and wait for you to come up with
    something that you feel confident with :)

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2020-06-15 14:51    [W:7.973 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site