Messages in this thread | | | Subject | Re: [PATCH 0/6] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts | From | Jonathan Marek <> | Date | Thu, 11 Jun 2020 14:14:43 -0400 |
| |
On 6/11/20 2:05 PM, Manivannan Sadhasivam wrote: > On Thu, Jun 04, 2020 at 07:22:21PM +0530, Manivannan Sadhasivam wrote: >> Hi, >> >> On Sat, May 23, 2020 at 10:38:06PM -0400, Jonathan Marek wrote: >>> Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. >>> >> >> I've tested this series on an SM8250 based board and able to get Type C (USB0) >> working. There are also couple of Type A ports (USB1) on that board behind a >> USB hub. It is probing fine but I don't see any activity while connecting a >> USB device. Will continue to debug and once I get them working, I'll add my >> Tested-by tag. >> > > So it turned out that I forgot to enable one regulator which kept the USB hub > powered down. After enabling that, both Type A ports are working. Hence, > > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Thanks, > Mani >
Thanks for testing it. Your Tested-by only applies to the relevant patches (patches 2 and 4 in this version) right? And can I also add your Tested-by tag to my other series (https://patchwork.kernel.org/cover/11567095/) which this depends on?
>> Thanks, >> Mani >> >>> Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a >>> few changes. Notably, the HDK865 dts has regulator config changed a bit based >>> on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150). >>> >>> Jonathan Marek (6): >>> arm64: dts: qcom: sm8150: add apps_smmu node >>> arm64: dts: qcom: sm8250: add apps_smmu node >>> arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes >>> arm64: dts: qcom: sm8250: Add USB and PHY device nodes >>> arm64: dts: qcom: add sm8150 hdk dts >>> arm64: dts: qcom: add sm8250 hdk dts >>> >>> arch/arm64/boot/dts/qcom/Makefile | 2 + >>> arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 ++++++++++++++++++++++++ >>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 180 +++++++++ >>> arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 +++++++++++++++++++++++ >>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 287 +++++++++++++++ >>> 5 files changed, 1384 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/sm8150-hdk.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/sm8250-hdk.dts >>> >>> -- >>> 2.26.1 >>>
| |