Messages in this thread | | | Date | Thu, 11 Jun 2020 11:12:54 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC |
| |
On Thu, Jun 11, 2020 at 10:12:46AM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > Add support for USB PHY on Intel LGM SoC.
...
> +static int get_flipped(struct tca_apb *ta, bool *flipped) > +{ > + union extcon_property_value property; > + int ret; > + > + ret = extcon_get_property(ta->phy.edev, EXTCON_USB_HOST, > + EXTCON_PROP_USB_TYPEC_POLARITY, &property); > + if (ret) { > + dev_err(ta->phy.dev, "no polarity property from extcon\n");
> + return false;
return ret;
> + } > + > + *flipped = property.intval; > +
> + return *flipped;
return 0;
> +}
...I suppose it should be as above.
...
> + ret = readl_poll_timeout(ctrl1, val, val & SRAM_INIT_DONE, > + 10, 10 * 1000);
On one line easier to read.
> + if (ret) { > + dev_err(ta->phy.dev, "SRAM init failed, 0x%x\n", val); > + return ret; > + }
...
> +static int phy_set_vbus(struct usb_phy *phy, int on) > +{ > + struct tca_apb *ta = container_of(phy, struct tca_apb, phy);
> + int ret = 0;
Assignment is redundant.
> + > + if (on) { > + ret = regulator_enable(ta->vbus); > + if (ret) > + dev_err(ta->phy.dev, "regulator not enabled\n"); > + } else { > + ret = regulator_disable(ta->vbus); > + if (ret) > + dev_err(ta->phy.dev, "regulator not disabled\n"); > + } > + > + return ret; > +}
...
> + ret = get_flipped(ta, &flipped); > + if (!ret) > + dev_err(ta->phy.dev, "no polarity property from extcon\n");
This should be fixed accordingly.
...
> + dev_info(ta->phy.dev, "connected%s\n", > + flipped ? " flipped" : "");
One line.
-- With Best Regards, Andy Shevchenko
| |