lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] afs: Fix memory leak in afs_put_sysnames()
Date
Markus Elfring <Markus.Elfring@web.de> wrote:

> > sysnames should be freed after refcnt being decreased to zero in
> > afs_put_sysnames().
>
> How do you think about a wording variant like the following?
>
> Release the sysnames object after its reference counter was decreased
> to zero.

I would say "reference count" not "reference counter" personally. I would
also say "afs_sysnames" rather than "sysnames". Perhaps something like:

Fix afs_put_sysnames() to actually free the specified afs_sysnames
object after its reference count has been decreased to zero and its
contents have been released.

> Will it matter to mention the size of the data structure "afs_sysnames"?

Why is it necessary to do so?

David

\
 
 \ /
  Last update: 2020-06-01 19:10    [W:0.057 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site