Messages in this thread | | | Date | Mon, 1 Jun 2020 18:52:04 +0300 | From | Serge Semin <> | Subject | Re: [PATCH v2 6/6] MAINTAINERS: Add maintainers for MIPS core drivers |
| |
On Mon, Jun 01, 2020 at 06:30:22PM +0300, Andy Shevchenko wrote: > On Mon, Jun 1, 2020 at 6:19 PM Serge Semin > <Sergey.Semin@baikalelectronics.ru> wrote: > > On Mon, Jun 01, 2020 at 04:56:21PM +0300, Andy Shevchenko wrote: > > > On Mon, Jun 1, 2020 at 3:26 PM Serge Semin > > > <Sergey.Semin@baikalelectronics.ru> wrote: > > > > > > > > Add myself as a maintainer of MIPS CPU and GIC IRQchip, MIPS GIC timer > > > > and MIPS CPS CPUidle drivers. > > > ... > > > > +MIPS CORE DRIVERS > > > > +M: Serge Semin <fancer.lancer@gmail.com> > > > > +L: linux-mips@vger.kernel.org > > > > +S: Supported > > > > +F: drivers/bus/mips_cdmm.c > > > > +F: drivers/irqchip/irq-mips-cpu.c > > > > +F: drivers/irqchip/irq-mips-gic.c > > > > +F: drivers/clocksource/mips-gic-timer.c > > > > +F: drivers/cpuidle/cpuidle-cps.c > > > > > > I think nowadays checkpatch.pl warns on wrong ordering in this data base. > > > > Alas it doesn't. >
> Ah, it definitely will. > it was relatively recently added by: > commit 9bbce40a4f72fe01a65669aee9f4036baa7fa26e > Author: Joe Perches <joe@perches.com> > Date: Tue May 26 10:36:34 2020 +1000 > > checkpatch: additional MAINTAINER section entry ordering checks > > > > Good point though. > > You're welcome.
Next time I won't forget that then. BTW the notes at the top of the MAINTAINERS file don't explicitly say about the files-list order. Only about the whole maintainers list entries order. Seeing the rest of the sub-entries like L:, M:, etc. aren't ordered then it's probably better to have an explicit statement, that files should be alphabetically listed, especially when checkpatch.pl starts warning about that.
-Sergey
> > -- > With Best Regards, > Andy Shevchenko
| |