| Date | Mon, 1 Jun 2020 07:16:32 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH 03/12] mm: abstract out wake_page_match() from wake_page_function() |
| |
On Tue, May 26, 2020 at 01:51:14PM -0600, Jens Axboe wrote: > +++ b/include/linux/pagemap.h > @@ -456,6 +456,43 @@ static inline pgoff_t linear_page_index(struct vm_area_struct *vma, > return pgoff; > } > > +/* This has the same layout as wait_bit_key - see fs/cachefiles/rdwr.c */ > +struct wait_page_key { > + struct page *page; > + int bit_nr; > + int page_match; > +};
I know you only moved the struct, and the comment along with it, but now that this struct is in pagemap.h, I think cachefiles should be updated to use wait_page_key instead of wait_bit_key. Dave?
|