lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 07/11] i2c: designware: Discard Cherry Trail model flag
From
Date
On 5/28/20 1:06 PM, Andy Shevchenko wrote:
> On Thu, May 28, 2020 at 12:33:17PM +0300, Serge Semin wrote:
>> A PM workaround activated by the flag MODEL_CHERRYTRAIL has been removed
>> since commit 9cbeeca05049 ("i2c: designware: Remove Cherry Trail PMIC I2C
>> bus pm_disabled workaround"), but the flag most likely by mistake has been
>> left in the Dw I2C drivers. Let's remove it. Since MODEL_MSCC_OCELOT is
>> the only model-flag left, redefine it to be 0x100 so setting a very first
>> bit in the MODEL_MASK bits range.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Conditionally, in case Wolfram and Jarkko are fine with shuffling model
> defines, which I consider an unneeded churn.
>
>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

I completely agree with Andy and more over, I didn't ack this version.
This was the version I acked:

https://www.spinics.net/lists/linux-i2c/msg45492.html

So in general please drop the received tags in case you decide to modify
patch since reviewers may not agree anymore with it.

That said, I'm fine with that minor code and commit log change. And
don't want to have yet another patchset version because it. Four
patchset versions during 2 days is a bit too much... Usual
recommendation is to wait for 1 week before posting a new version
especially if patchset is under active discussion.

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

\
 
 \ /
  Last update: 2020-06-01 10:55    [W:0.052 / U:2.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site