Messages in this thread | | | Subject | Re: [PATCH] power: supply: bq24190_charger.c: call pm_runtime_put in pm_runtime_get_sync failed case | From | Markus Elfring <> | Date | Mon, 1 Jun 2020 10:01:20 +0200 |
| |
> Even in failed case of pm_runtime_get_sync, the usage_count > is incremented. In order to keep the usage_count with correct > value call pm_runtime_put_autosuspend.
* I find the word “usage_count” questionable in this change description.
* Will the tag “Fixes” become relevant for the commit message?
* Can an other label be more helpful than “out”?
* Would you like to take another look at a related update suggestion like “power: supply: bq24190_charger: Fix runtime PM imbalance on error”? https://lore.kernel.org/linux-pm/20200525110540.6949-1-dinghao.liu@zju.edu.cn/ https://lore.kernel.org/patchwork/patch/1246783/
Regards, Markus
| |