lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition
From
Date


On 01/06/2020 06:02, Benjamin Herrenschmidt wrote:
> On Wed, 2020-05-27 at 09:49 +0100, Stefan Hajnoczi wrote:
>> What about feature bits or a API version number field? If you add
>> features to the NE driver, how will userspace detect them?
>>
>> Even if you intend to always compile userspace against the exact kernel
>> headers that the program will run on, it can still be useful to have an
>> API version for informational purposes and to easily prevent user
>> errors (running a new userspace binary on an old kernel where the API is
>> different).
>>
>> Finally, reserved struct fields may come in handy in the future. That
>> way userspace and the kernel don't need to explicitly handle multiple
>> struct sizes.
> Beware, Greg might disagree :)
>
> That said, yes, at least a way to query the API version would be
> useful.

I see there are several thoughts with regard to extensions possibilities. :)

I added an ioctl for getting the API version, we have now a way to query
that info. Also, I updated the sample in this patch series to check for
the API version.

Thanks,
Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
\
 
 \ /
  Last update: 2020-06-01 09:21    [W:0.108 / U:2.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site