lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 051/177] gpio: tegra: mask GPIO IRQs during IRQ shutdown
    Date
    From: Stephen Warren <swarren@nvidia.com>

    [ Upstream commit 0cf253eed5d2bdf7bb3152457b38f39b012955f7 ]

    The driver currently leaves GPIO IRQs unmasked even when the GPIO IRQ
    client has released the GPIO IRQ. This allows the HW to raise IRQs, and
    SW to process them, after shutdown. Fix this by masking the IRQ when it's
    shut down. This is usually taken care of by the irqchip core, but since
    this driver has a custom irq_shutdown implementation, it must do this
    explicitly itself.

    Signed-off-by: Stephen Warren <swarren@nvidia.com>
    Link: https://lore.kernel.org/r/20200427232605.11608-1-swarren@wwwdotorg.org
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpio/gpio-tegra.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
    index acb99eff9939..86568154cdb3 100644
    --- a/drivers/gpio/gpio-tegra.c
    +++ b/drivers/gpio/gpio-tegra.c
    @@ -368,6 +368,7 @@ static void tegra_gpio_irq_shutdown(struct irq_data *d)
    struct tegra_gpio_info *tgi = bank->tgi;
    unsigned int gpio = d->hwirq;

    + tegra_gpio_irq_mask(d);
    gpiochip_unlock_as_irq(&tgi->gc, gpio);
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-01 20:41    [W:4.276 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site