lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 078/177] hwmon: (nct7904) Fix incorrect range of temperature limit registers
    Date
    From: Amy Shih <amy.shih@advantech.com.tw>

    [ Upstream commit 7b2fd270af27edaf02acb41a7babe805a9441914 ]

    The format of temperature limitation registers are 8-bit 2's complement
    and the range is -128~127.
    Converts the reading value to signed char to fix the incorrect range
    of temperature limitation registers.

    Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/nct7904.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
    index 281c81edabc6..dfb122b5e1b7 100644
    --- a/drivers/hwmon/nct7904.c
    +++ b/drivers/hwmon/nct7904.c
    @@ -356,6 +356,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
    struct nct7904_data *data = dev_get_drvdata(dev);
    int ret, temp;
    unsigned int reg1, reg2, reg3;
    + s8 temps;

    switch (attr) {
    case hwmon_temp_input:
    @@ -461,7 +462,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,

    if (ret < 0)
    return ret;
    - *val = ret * 1000;
    + temps = ret;
    + *val = temps * 1000;
    return 0;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-01 20:15    [W:4.516 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site