lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 025/177] net/mlx5: Fix memory leak in mlx5_events_init
    Date
    From: Moshe Shemesh <moshe@mellanox.com>

    [ Upstream commit df14ad1eccb04a4a28c90389214dbacab085b244 ]

    Fix memory leak in mlx5_events_init(), in case
    create_single_thread_workqueue() fails, events
    struct should be freed.

    Fixes: 5d3c537f9070 ("net/mlx5: Handle event of power detection in the PCIE slot")
    Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
    Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/events.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mellanox/mlx5/core/events.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/events.c
    @@ -346,8 +346,10 @@ int mlx5_events_init(struct mlx5_core_de
    events->dev = dev;
    dev->priv.events = events;
    events->wq = create_singlethread_workqueue("mlx5_events");
    - if (!events->wq)
    + if (!events->wq) {
    + kfree(events);
    return -ENOMEM;
    + }
    INIT_WORK(&events->pcie_core_work, mlx5_pcie_event);

    return 0;

    \
     
     \ /
      Last update: 2020-06-01 20:12    [W:5.336 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site