lkml.org 
[lkml]   [2020]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed
On Sat,  9 May 2020 14:04:52 +0200 Arnd Bergmann wrote:
> I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
> and CONFIG_GIANFAR=y:
>
> x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): undefined reference to `fixed_phy_change_carrier'
>
> It seems the same thing can happen with dpaa and ucc_geth, so change
> all three to do an explicit 'select FIXED_PHY'.
>
> The fixed-phy driver actually has an alternative stub function that
> theoretically allows building network drivers when fixed-phy is
> disabled, but I don't see how that would help here, as the drivers
> presumably would not work then.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> + select FIXED_PHY

I think FIXED_PHY needs to be optional, depends on what the board has
connected to the MAC it may not be needed, right PHY folks? We probably
need the

depends on FIXED_PHY || !FIXED_PHY

dance.

\
 
 \ /
  Last update: 2020-05-09 22:24    [W:0.050 / U:2.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site