Messages in this thread | | | Date | Sat, 9 May 2020 13:24:27 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed |
| |
On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote: > I ran into a randconfig build failure with CONFIG_FIXED_PHY=m > and CONFIG_GIANFAR=y: > > x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): undefined reference to `fixed_phy_change_carrier' > > It seems the same thing can happen with dpaa and ucc_geth, so change > all three to do an explicit 'select FIXED_PHY'. > > The fixed-phy driver actually has an alternative stub function that > theoretically allows building network drivers when fixed-phy is > disabled, but I don't see how that would help here, as the drivers > presumably would not work then. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> + select FIXED_PHY
I think FIXED_PHY needs to be optional, depends on what the board has connected to the MAC it may not be needed, right PHY folks? We probably need the
depends on FIXED_PHY || !FIXED_PHY
dance.
| |