Messages in this thread | | | Date | Sat, 9 May 2020 19:05:32 +0200 | From | Greg KH <> | Subject | Re: [PATCH] Driver: Adding helper macro for platform_driver boilerplate. |
| |
On Sat, May 09, 2020 at 03:37:16PM +0530, Harshal Chaudhari wrote: > From: Harshal <harshalchau04@gmail.com> > > For simple module that contain a single platform_driver without any additional setup code then ends up being a block > of duplicated boilerplate. > > This patch add a new micro, module_platform_driver(), which replace the module_init()/module_exit() registrations > with template functions.
Please properly wrap your changelog text.
And fixup the Subject line to match other patches for this driver.
And the text needs to be revised a bit to say what this really is doing, as what you describe is not correct.
> > Signed-off-by: harshal chaudhari <harshalchau04@gmail.com>
Finally, this does not match your "From:" line for the patch, which means I couldn't take it even if all of the above was correct :(
Please fix up and resend.
thanks,
greg k-h
| |